chore(rivet): mark RQ-58-SELDSL and RQ-58-FLAKE implemented (#242) - #1007
Merged
Conversation
Both shipped and merged with all 9 required contexts green — SELDSL as #1004 (50 -> 74 Rocq-proved rules; sel_dsl_rules reads 74 on main) and FLAKE as #1006 (29b1a85) — but neither lane bumped its own rivet status, so the release-readiness query still counted them as unfinished scope. Release readiness is a QUERY over these statuses, not an opinion, so a stale 'proposed' on merged work makes the v0.58 gate under-report. Caught by reading the scope on fresh main rather than at release assembly, which is where it would otherwise have surfaced as a late blocker. Refs #242.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both lanes shipped and merged with all 9 required contexts green, but neither bumped its own rivet status, so
artifacts/release-v0.58.yamlstill carriedstatus: proposedfor work that is onmain.RQ-58-SELDSLsel_dsl_rulesderives 74 (was 50); selector code −79 linesRQ-58-FLAKE29b1a853; stale-ELF guard + 10/58 sites convertedWhy this is worth its own PR. Release readiness is a query over these statuses, not an opinion — "the release is cuttable when every artifact in scope is implemented/verified". A stale
proposedon merged work makes the v0.58 gate under-report its own scope, and it would otherwise have surfaced at release assembly as a late blocker on work that was actually done weeks earlier in the hub.Found by re-reading the scope against fresh
mainrather than trusting the lane reports — the same discipline that caught 4 factual errors in the v0.57 CHANGELOG.claim_check.pyis 49/49 with the change.Refs #242.